Skip to content

Conversation

@Krishn1412
Copy link

@Krishn1412 Krishn1412 commented Nov 9, 2025

  • The PR is for the issue.
  • I have added the tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

Summary

I have created two files in the cext crate similar to what is done in the src folder, one wrap_angle.rs and angle_resgistry.rs .

@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Nov 9, 2025
@Krishn1412
Copy link
Author

Hello @mtreinish, I have raised a PR for adding angle bound features in the C API (Its still a WIP). While adding the keyword check_angle_bounds and angle_bounds in the C API, I noticed that the C API calls the rust native version of Target implementation while the angle bounds have been added in the other implementation. How should we proceed in this case? TIA for the help.

@Krishn1412 Krishn1412 marked this pull request as ready for review November 14, 2025 07:21
@Krishn1412 Krishn1412 requested a review from a team as a code owner November 14, 2025 07:21
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Community PR PRs from contributors that are not 'members' of the Qiskit repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants